Skip to content

fix/extend some mir-opt comments#154297

Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
RalfJung:mir-opt-comments
Mar 24, 2026
Merged

fix/extend some mir-opt comments#154297
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
RalfJung:mir-opt-comments

Conversation

@RalfJung
Copy link
Copy Markdown
Member

@RalfJung RalfJung commented Mar 24, 2026

Looks like CopyProp was refactored without updating that comment.

And for GVN, I think this is what you had in mind @cjgillot but would be great if you could have a look.

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 24, 2026

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 24, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 24, 2026

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler, mir, mir-opt
  • compiler, mir, mir-opt expanded to 69 candidates
  • Random selection from 12 candidates

dianqk
dianqk approved these changes Mar 24, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@dianqk dianqk left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Perhaps the provenance can be removed after #150485. I'll check that later.

View changes since this review

@dianqk
Copy link
Copy Markdown
Member

dianqk commented Mar 24, 2026

r? me
@bors r+ rollup=always

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 24, 2026

📌 Commit fb2b003 has been approved by dianqk

It is now in the queue for this repository.

@rustbot rustbot assigned dianqk and unassigned davidtwco Mar 24, 2026
@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Mar 24, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Mar 24, 2026
@bors
Auto merge of #154300 - JonathanBrouwer:rollup-MkFxTPv, r=JonathanBro…
0312931 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #153434 (Use a safe `BucketIndex` abstraction in `VecCache`)
 - #154133 (Defer codegen for the VaList Drop impl to actual uses)
 - #154297 (fix/extend some mir-opt comments)
 - #154299 (document some functions on AttributeExt)
@rust-bors rust-bors bot merged commit a5a286d into rust-lang:main Mar 24, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 24, 2026
@RalfJung RalfJung deleted the mir-opt-comments branch March 25, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dianqk dianqk dianqk approved these changes

Assignees

@dianqk dianqk

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

4 participants

@RalfJung @rustbot @dianqk @davidtwco